linux-kernel - Re: [PATCH 1/3] arm64: dts: qcom: msm8916: correct LPASS CPU clocks order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91b5cbb7-f3cf-c77d-faf4-bd1000f3e363@linaro.org>
Date:   Mon, 8 May 2023 09:46:16 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Vinod Koul <vkoul@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: msm8916: correct LPASS CPU clocks
 order



On 7.05.2023 19:45, Krzysztof Kozlowski wrote:
> Re-order the clocks for LPASS CPU node to match the bindings (Linux
> driver takes by name):
> 
>   msm8916-asus-z00l.dtb: audio-controller@...8000: clock-names:1: 'mi2s-bit-clk0' was expected
>   msm8916-asus-z00l.dtb: audio-controller@...8000: clock-names:2: 'mi2s-bit-clk1' was expected
>   msm8916-asus-z00l.dtb: audio-controller@...8000: clock-names:3: 'mi2s-bit-clk2' was expected
>   msm8916-asus-z00l.dtb: audio-controller@...8000: clock-names:4: 'mi2s-bit-clk3' was expected
>   msm8916-asus-z00l.dtb: audio-controller@...8000: clock-names:5: 'pcnoc-mport-clk' was expected
>   msm8916-asus-z00l.dtb: audio-controller@...8000: clock-names:6: 'pcnoc-sway-clk' was expected
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index bf88c10ff55b..e7ae81296b20 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1520,20 +1520,20 @@ lpass: audio-controller@...8000 {
>  			 * Primary/Secondary MI2S both use the PRI_I2S_CLK.
>  			 */
>  			clocks = <&gcc GCC_ULTAUDIO_AHBFABRIC_IXFABRIC_CLK>,
> -				 <&gcc GCC_ULTAUDIO_PCNOC_MPORT_CLK>,
> -				 <&gcc GCC_ULTAUDIO_PCNOC_SWAY_CLK>,
>  				 <&gcc GCC_ULTAUDIO_LPAIF_PRI_I2S_CLK>,
>  				 <&gcc GCC_ULTAUDIO_LPAIF_PRI_I2S_CLK>,
>  				 <&gcc GCC_ULTAUDIO_LPAIF_SEC_I2S_CLK>,
> -				 <&gcc GCC_ULTAUDIO_LPAIF_AUX_I2S_CLK>;
> +				 <&gcc GCC_ULTAUDIO_LPAIF_AUX_I2S_CLK>,
> +				 <&gcc GCC_ULTAUDIO_PCNOC_MPORT_CLK>,
> +				 <&gcc GCC_ULTAUDIO_PCNOC_SWAY_CLK>;
>  
>  			clock-names = "ahbix-clk",
> -					"pcnoc-mport-clk",
> -					"pcnoc-sway-clk",
>  					"mi2s-bit-clk0",
>  					"mi2s-bit-clk1",
>  					"mi2s-bit-clk2",
> -					"mi2s-bit-clk3";
> +					"mi2s-bit-clk3",
> +					"pcnoc-mport-clk",
> +					"pcnoc-sway-clk";
>  			#sound-dai-cells = <1>;
>  
>  			interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;