[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1bb3aa1d-1f01-4260-9ebd-598f3dffa420@kili.mountain>
Date: Mon, 8 May 2023 12:42:23 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Brandon Pollack <brpol@...omium.org>, linux-kernel@...r.kernel.org,
masahiroy@...nel.org, ojeda@...nel.org, alex.gaynor@...il.com,
keescook@...omium.org, nathan@...nel.org
Subject: Re: [PATCH v2] .gitignore: ignore smatch generated files
On Mon, May 08, 2023 at 11:29:47AM +0200, Miguel Ojeda wrote:
> On Mon, May 8, 2023 at 7:54 AM Brandon Pollack <brpol@...omium.org> wrote:
> >
> > ignore smatch generated files.
>
> Sorry, I should have mentioned this in v1: this line just repeats the
> title -- please also give the rationale for the change in the commit
> message, not just what changed.
>
I secretly wanted to say both things you said. Also please start the
commit message with a Capital letter. Here is my proposed commit
message:
The Smatch static checker creates some data files in the kernel root
directory. Add them to the .gitignore file so that no one accidentally
commits them.
regards,
dan carpenter
Powered by blists - more mailing lists