linux-kernel - Re: [PATCH 2/2] bus: qcom-ebi2: simplify the code in qcom_ebi2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 May 2023 15:35:56 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Ziliang Liao <saraday@...t.edu.cn>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        hust-os-kernel-patches@...glegroups.com,
        Dongliang Mu <dzm91@...t.edu.cn>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] bus: qcom-ebi2: simplify the code in qcom_ebi2_probe()

On Sun, Apr 30, 2023 at 2:54 PM Ziliang Liao <saraday@...t.edu.cn> wrote:

> The code use platform_get_resource() and devm_ioremap_resource() to
> allocate memory resources for the device. It can be simplified by using
> devm_platform_ioremap_resource().
>
> Fixes: 335a12754808 ("bus: qcom: add EBI2 driver")

It doesn't need Fixes: if it's not a bug, but who cares. Maybe
the stable maintainers care.

> Signed-off-by: Ziliang Liao <saraday@...t.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij