linux-kernel - Re: [PATCH v1 1/1] scripts/tags.sh: Fix gtags generation for O= kernel builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 May 2023 16:11:03 +0200
From:   "Ahmed S. Darwish" <darwi@...utronix.de>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kbuild@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] scripts/tags.sh: Fix gtags generation for O=
 kernel builds

Hi Masahiro,

On Fri, 05 May 2023, Masahiro Yamada wrote:
>
> It is wrong to check whether you are building out of the
> source tree.  See line 159 of the Makefile.
>

Oh, didn't think about that case. Thanks for the reference and the
further clarification in reply.

I'll remove the ${O} check then and use saner mechanisms.

> BTW, this patch does not work for me.
> It spits a ton of "not found" warnings, then generates
> empty tags.
>
>
> $ make O=build gtags

Interesting...

When doing:

  $ make O=../build gtags

  scripts/tags.sh "$tree" variable is set to the absolute path of the
  kernel source tree. Thus all the paths fed to gtags are absolute and
  this patch series works.

When doing what you tested with:

  $ make O=build/ gtags

  scripts/tags.sh "$tree" variable is set to the path of the kernel
  source tree *relative* to O=build/. So in that case kernel source
  "$tree" equals ".."

  With this series, the build will fail as gtags current working dir is
  the kernel source tree, and all the fed paths are thus invalid as
  they're relative to O=build/ instead.

  Without this series the build will still fail given the original
  problem of having the files "outside the source tree", where gtags
  thinks the source tree is "build/".

I'll think of something that can cover the both cases.

Kind regards,
Ahmed

--
Linutronix GmbH