linux-kernel - Re: [PATCH] drm/amdgpu: Remove the unused variable golden_settings_gc_9_4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 May 2023 10:48:43 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     alexander.deucher@....com, Xinhui.Pan@....com,
        Abaci Robot <abaci@...ux.alibaba.com>,
        linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
        sumit.semwal@...aro.org, linaro-mm-sig@...ts.linaro.org,
        dri-devel@...ts.freedesktop.org, christian.koenig@....com,
        linux-media@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: Remove the unused variable golden_settings_gc_9_4_3

Applied.  Thanks!

On Sat, May 6, 2023 at 4:11 AM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> Variable golden_settings_gc_9_4_3 is not effectively used, so delete it.
>
> drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c:48:38: warning: ‘golden_settings_gc_9_4_3’ defined but not used.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4877
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> index 312491455382..74be46d382f4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> @@ -45,10 +45,6 @@ MODULE_FIRMWARE("amdgpu/gc_9_4_3_rlc.bin");
>  #define GFX9_MEC_HPD_SIZE 4096
>  #define RLCG_UCODE_LOADING_START_ADDRESS 0x00002000L
>
> -static const struct soc15_reg_golden golden_settings_gc_9_4_3[] = {
> -
> -};
> -
>  static void gfx_v9_4_3_set_ring_funcs(struct amdgpu_device *adev);
>  static void gfx_v9_4_3_set_irq_funcs(struct amdgpu_device *adev);
>  static void gfx_v9_4_3_set_gds_init(struct amdgpu_device *adev);
> --
> 2.20.1.7.g153144c
>