linux-kernel - Re: [PATCH v3 0/2] Fixing check patch styling issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa975430-1ca1-fc89-dfa3-f28b2228b6a2@intel.com>
Date:   Mon, 8 May 2023 09:01:54 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Raghu Halharvi <raghuhack78@...il.com>, linux-cxl@...r.kernel.org,
        Alison Schofield <alison.schofield@...el.com>,
        ira.weiny@...el.com, bwidawsk@...nel.org, dan.j.williams@...el.com,
        vishal.l.verma@...el.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/2] Fixing check patch styling issues



On 5/8/23 1:25 AM, Raghu Halharvi wrote:
> v3 changes:
> - Update the cover letter and commit message with full author
>    name(Fabio/Alison)
> - Correct the "typo error" in commit message(Fabio)

Hi Raghu,
Please make sure you pick up all the review tags given by reviewers in 
the previous round and also add them to the respective patches.

Using the b4 tool can do that for you.
https://people.kernel.org/monsieuricon/introducing-b4-and-patch-attestation


> 
> v2 changes:
> Thanks Alison, Ira for your comments, modified the v1 patches as
> suggested.
> Dropped the patch containing tab changes in port.c
> 
> v1 cover letter:
> The following patches are cleanup or fixing the styling issues found
> using checkpatch
> 
> In cxl/core/mbox.c, in case of null check failure, returning errno or
> -ENOMEM in this case is good enough, removing the redundant dev_err
> message.
> 
> In cxl/core/region.c, the else is not required after the return
> statement, cleaned it up.
> 
> Verified the build and sanity by booting the guest VM using the freshly
> built components.
> 
> Raghu Halharvi (2):
>    cxl/mbox: Remove redundant dev_err() after failed mem alloc
>    cxl/region: Remove else after return statement
> 
>   drivers/cxl/core/mbox.c   | 4 +---
>   drivers/cxl/core/region.c | 8 ++++----
>   2 files changed, 5 insertions(+), 7 deletions(-)
>