linux-kernel - Re: [PATCH] wifi: iwlwifi: Use default @max_active for trans_pcie->rba.alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68404955637d963f3111a60d3d99c1be8b5d4045.camel@sipsolutions.net>
Date:   Mon, 08 May 2023 18:05:11 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Tejun Heo <tj@...nel.org>
Cc:     jiangshanlai@...il.com, linux-kernel@...r.kernel.org,
        kernel-team@...a.com, Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Gregory Greenman <gregory.greenman@...el.com>,
        Avraham Stern <avraham.stern@...el.com>,
        Kees Cook <keescook@...omium.org>,
        Mordechay Goodstein <mordechay.goodstein@...el.com>,
        "Haim, Dreyfuss" <haim.dreyfuss@...el.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] wifi: iwlwifi: Use default @max_active for
 trans_pcie->rba.alloc_wq

On Fri, 2023-05-05 at 12:52 -1000, Tejun Heo wrote:
> trans_pcie->rba.alloc_wq only hosts a single work item and thus doesn't need
> explicit concurrency limit. Let's use the default @max_active. This doesn't
> cost anything and clearly expresses that @max_active doesn't matter.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Gregory Greenman <gregory.greenman@...el.com>
> Cc: Johannes Berg <johannes.berg@...el.com>
> Cc: Avraham Stern <avraham.stern@...el.com>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Mordechay Goodstein <mordechay.goodstein@...el.com>
> Cc: "Haim, Dreyfuss" <haim.dreyfuss@...el.com>
> Cc: linux-wireless@...r.kernel.org
> Cc: netdev@...r.kernel.org
> 

Sure, that seems fine too.

Acked-by: Johannes Berg <johannes.berg@...el.com>

For whatever that's worth, might better to get Gregory ;-)

johannes

> --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> @@ -3577,7 +3577,7 @@ struct iwl_trans *iwl_trans_pcie_alloc(s
>  	init_waitqueue_head(&trans_pcie->imr_waitq);
>  
>  	trans_pcie->rba.alloc_wq = alloc_workqueue("rb_allocator",
> -						   WQ_HIGHPRI | WQ_UNBOUND, 1);
> +						   WQ_HIGHPRI | WQ_UNBOUND, 0);
>  	if (!trans_pcie->rba.alloc_wq) {
>  		ret = -ENOMEM;
>  		goto out_free_trans;
>