linux-kernel - Re: [PATCH v2 2/2] power: supply: remove unneeded include of linux/leds.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230508122213.2fj4kinuxr2ntoob@mercury.elektranox.org>
Date:   Mon, 8 May 2023 14:22:13 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH v2 2/2] power: supply: remove unneeded include of
 linux/leds.h

Hi,

On Tue, May 02, 2023 at 06:28:45AM +0200, Thomas Weißschuh wrote:
> Instead of including the full linux/leds.h header file a single
> forward-declaration is enough.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---

Acked-by: Sebastian Reichel <sebastian.reichel@...labora.com>

-- Sebastian

>  include/linux/power_supply.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index a427f13c757f..dc5e17e8c919 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -14,10 +14,11 @@
>  
>  #include <linux/device.h>
>  #include <linux/workqueue.h>
> -#include <linux/leds.h>
>  #include <linux/spinlock.h>
>  #include <linux/notifier.h>
>  
> +struct led_trigger;
> +
>  /*
>   * All voltages, currents, charges, energies, time and temperatures in uV,
>   * µA, µAh, µWh, seconds and tenths of degree Celsius unless otherwise
> 
> -- 
> 2.40.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)