linux-kernel - Re: [PATCH v2] tools/nolibc: Fix build of stdio.h due to header ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <31510739-c069-56fc-a1d2-43a0c86aeb2c@linuxfoundation.org>
Date:   Mon, 8 May 2023 11:18:35 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Mark Brown <broonie@...nel.org>, Willy Tarreau <w@....eu>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Thomas Weißschuh <linux@...ssschuh.net>
Cc:     Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] tools/nolibc: Fix build of stdio.h due to header
 ordering

On 5/8/23 07:30, Mark Brown wrote:
> When we added fd based file streams we created references to STx_FILENO in
> stdio.h but these constants are declared in unistd.h which is the last file
> included by the top level nolibc.h meaning those constants are not defined
> when we try to build stdio.h. This causes programs using nolibc.h to fail
> to build.
> 
> Reorder the headers to avoid this issue.
> 
> Fixes: d449546c957f ("tools/nolibc: implement fd-based FILE streams")
> Acked-by: Willy Tarreau <w@....eu>
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---

Applied now to linux-kselftest fixes for 6.4-rc2

thanks,
-- Shuah