linux-kernel - Re: [PATCH v2] KVM: VMX: add MSR_IA32_TSX_CTRL into msrs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALMp9eS7KuGkMiZ-RQoYqTQ7TyzLct3OVUCuJUorkg3WBVJ3zQ@mail.gmail.com>
Date:   Mon, 8 May 2023 10:28:15 -0700
From:   Jim Mattson <jmattson@...gle.com>
To:     Xiaoyao Li <xiaoyao.li@...el.com>
Cc:     Mingwei Zhang <mizhang@...gle.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] KVM: VMX: add MSR_IA32_TSX_CTRL into msrs_to_save

On Sun, May 7, 2023 at 6:54 PM Xiaoyao Li <xiaoyao.li@...el.com> wrote:
>
> On 5/5/2023 2:18 AM, Mingwei Zhang wrote:
> > Add MSR_IA32_TSX_CTRL into msrs_to_save[] to explicitly tell userspace to
> > save/restore the register value during migration. Missing this may cause
> > userspace that relies on KVM ioctl(KVM_GET_MSR_INDEX_LIST) fail to port the
> > value to the target VM.
> >
> > In addition, there is no need to add MSR_IA32_TSX_CTRL when
> > ARCH_CAP_TSX_CTRL_MSR is not supported in guest. So add the checking in
> > kvm_probe_msr_to_save().
> >
> > Fixes: b07a5c53d42a ("KVM: vmx: use MSR_IA32_TSX_CTRL to hard-disable TSX on guest that lack it")
>
> I wonder it's the fix for this commit.
>
> Apart from this,
>
> Reviewed-by: Xiaoyao Li <xiaoyao.li@...el.com>

I concur.

How about:

Fixes: ea732b38b341 ("KVM: vmx: implement MSR_IA32_TSX_CTRL disable
RTM functionality")

Reviewed-by: Jim Mattson <jmattson@...gle.com>