linux-kernel - Re: [PATCH] x86: make config X86_FEATURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKXUXMxO4b-8wT-88fJ=++woH-p79_4R-vUr=aELNFYinGcEuw@mail.gmail.com>
Date:   Tue, 9 May 2023 20:20:50 +0200
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Dave Hansen <dave.hansen@...el.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H . Peter Anvin" <hpa@...or.com>, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: make config X86_FEATURE_NAMES visible with EXPERT

On Tue, May 9, 2023 at 4:07 PM Dave Hansen <dave.hansen@...el.com> wrote:
>
> On 5/9/23 01:40, Lukas Bulwahn wrote:
> > Commit 6a108a14fa35 ("kconfig: rename CONFIG_EMBEDDED to CONFIG_EXPERT")
> > introduces CONFIG_EXPERT to carry the previous intent of CONFIG_EMBEDDED
> > and just gives that intent a much better name.
>
> That was quite the changelog, and I'm still not quite sure:
>
> What is the problem with the existing code?
>
> What is the end user visible impact of this problem and of this proposed
> change?
>

Thanks, Dave, for your feedback.

The commit message is so lengthy, as I copied it from the original
cover letter into each commit, but I agree with your feedback.

So maybe this commit message fits better:

To simplify build configurations, the CONFIG_EMBEDDED is to be
removed. All configs that are only visible with CONFIG_EMBEDDED=y
shall be now visible with CONFIG_EXPERT=y.

In the x86 architecture, the config X86_FEATURE_NAMES is visible when
CONFIG_EMBEDDED is enabled. Now, make the config X86_FEATURE_NAMES
visible when CONFIG_EXPERT is enabled.

Dave, what do you think? If that is good enough for you, I will send
an updated patch with that commit message.

Lukas