lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230508185257.2e4f7434@kernel.org>
Date:   Mon, 8 May 2023 18:52:57 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Taichi Nishimura <awkrail01@...il.com>
Cc:     davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH] add braces to rt_type == RTN_BROADCAST case

On Tue,  9 May 2023 10:36:01 +0900 Taichi Nishimura wrote:
> Add braces to rt->rt_type == RTN_BROADCAST to make it easier
> to grasp the if-else-if statement.
> I think that it is ok to remove braces of rt_type == RTN_MULTICAST
> because IP_UPD_PO_STATS is oneliner.

I'm sorry but unfortunately we don't take pure coding style changes
(AKA checkpatch changes) in networking because they make backports
harder for little gain.
-- 
pw-bot: reject

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ