linux-kernel - Re: [PATCH bpf-next] arm64,bpf: Support struct arguments in the BPF trampoline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7cf68bd6-c103-6b0b-1929-86b53079db38@meta.com>
Date:   Tue, 9 May 2023 06:37:44 -0700
From:   Yonghong Song <yhs@...a.com>
To:     Florent Revest <revest@...omium.org>, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc:     ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        kpsingh@...nel.org, mark.rutland@....com, xukuohai@...weicloud.com,
        zlim.lnx@...il.com
Subject: Re: [PATCH bpf-next] arm64,bpf: Support struct arguments in the BPF
 trampoline



On 5/8/23 9:46 AM, Florent Revest wrote:
> This extends the BPF trampoline JIT to support attachment to functions
> that take small structures (up to 128bit) as argument. This is trivially
> achieved by saving/restoring a number of "argument registers" rather
> than a number of arguments.
> 
> The AAPCS64 section 6.8.2 describes the parameter passing ABI.
> "Composite types" (like C structs) below 16 bytes (as enforced by the
> BPF verifier) are provided as part of the 8 argument registers as
> explained in the section C.12.
> 
> Signed-off-by: Florent Revest <revest@...omium.org>
LGTM. Thanks for adding support for arm64!

Acked-by: Yonghong Song <yhs@...com>