linux-kernel - Re: [PATCH 11/13] crypto: octeontx2: Use alloc_ordered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZFmthqP+hpTZM2X3@gondor.apana.org.au>
Date:   Tue, 9 May 2023 10:18:46 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Tejun Heo <tj@...nel.org>
Cc:     jiangshanlai@...il.com, linux-kernel@...r.kernel.org,
        kernel-team@...a.com, Boris Brezillon <bbrezillon@...nel.org>,
        Arnaud Ebalard <arno@...isbad.org>,
        Srujana Challa <schalla@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Shijith Thotton <sthotton@...vell.com>,
        Vladis Dronov <vdronov@...hat.com>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Alexander Lobakin <alobakin@...me>,
        Minghao Chi <chi.minghao@....com.cn>,
        ye xingchen <ye.xingchen@....com.cn>,
        linux-crypto@...r.kernel.org
Subject: Re: [PATCH 11/13] crypto: octeontx2: Use alloc_ordered_workqueue()
 to create ordered workqueues

On Mon, May 08, 2023 at 03:50:30PM -1000, Tejun Heo wrote:
> BACKGROUND
> ==========
> 
> When multiple work items are queued to a workqueue, their execution order
> doesn't match the queueing order. They may get executed in any order and
> simultaneously. When fully serialized execution - one by one in the queueing
> order - is needed, an ordered workqueue should be used which can be created
> with alloc_ordered_workqueue().
> 
> However, alloc_ordered_workqueue() was a later addition. Before it, an
> ordered workqueue could be obtained by creating an UNBOUND workqueue with
> @max_active==1. This originally was an implementation side-effect which was
> broken by 4c16bd327c74 ("workqueue: restore WQ_UNBOUND/max_active==1 to be
> ordered"). Because there were users that depended on the ordered execution,
> 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be ordered")
> made workqueue allocation path to implicitly promote UNBOUND workqueues w/
> @max_active==1 to ordered workqueues.
> 
> While this has worked okay, overloading the UNBOUND allocation interface
> this way creates other issues. It's difficult to tell whether a given
> workqueue actually needs to be ordered and users that legitimately want a
> min concurrency level wq unexpectedly gets an ordered one instead. With
> planned UNBOUND workqueue updates to improve execution locality and more
> prevalence of chiplet designs which can benefit from such improvements, this
> isn't a state we wanna be in forever.
> 
> This patch series audits all callsites that create an UNBOUND workqueue w/
> @max_active==1 and converts them to alloc_ordered_workqueue() as necessary.
> 
> WHAT TO LOOK FOR
> ================
> 
> The conversions are from
> 
>   alloc_workqueue(WQ_UNBOUND | flags, 1, args..)
> 
> to
> 
>   alloc_ordered_workqueue(flags, args...)
> 
> which don't cause any functional changes. If you know that fully ordered
> execution is not ncessary, please let me know. I'll drop the conversion and
> instead add a comment noting the fact to reduce confusion while conversion
> is in progress.
> 
> If you aren't fully sure, it's completely fine to let the conversion
> through. The behavior will stay exactly the same and we can always
> reconsider later.
> 
> As there are follow-up workqueue core changes, I'd really appreciate if the
> patch can be routed through the workqueue tree w/ your acks. Thanks.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Boris Brezillon <bbrezillon@...nel.org>
> Cc: Arnaud Ebalard <arno@...isbad.org>
> Cc: Srujana Challa <schalla@...vell.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Shijith Thotton <sthotton@...vell.com>
> Cc: Vladis Dronov <vdronov@...hat.com>
> Cc: Vincent Mailhol <mailhol.vincent@...adoo.fr>
> Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>
> Cc: Alexander Lobakin <alobakin@...me>
> Cc: Minghao Chi <chi.minghao@....com.cn>
> Cc: ye xingchen <ye.xingchen@....com.cn>
> Cc: linux-crypto@...r.kernel.org
> ---
>  drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c | 12 ++++++------
>  drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c |  6 +++---
>  2 files changed, 9 insertions(+), 9 deletions(-)

Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt