linux-kernel - Re: [PATCH v4 2/2] cxl/region: Remove else after return statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <faad76bc-897b-c2ed-2a39-97a2710efe4b@intel.com>
Date:   Tue, 9 May 2023 08:30:37 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Raghu Halharvi <raghuhack78@...il.com>, linux-cxl@...r.kernel.org,
        Alison Schofield <alison.schofield@...el.com>,
        ira.weiny@...el.com, bwidawsk@...nel.org, dan.j.williams@...el.com,
        vishal.l.verma@...el.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] cxl/region: Remove else after return statement



On 5/9/23 2:50 AM, Raghu Halharvi wrote:
> Issue found with checkpatch
> 
> The else section here is redundant after return statement, removing it.
> Sanity and correctness is not affected due to this fix.
> 
> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> Reviewed-by: Dave Jiang <dave.jiang@...el.com>

Duplicate tags here. Just FYI. :)
> Signed-off-by: Raghu Halharvi <raghuhack78@...il.com>
> ---
>   drivers/cxl/core/region.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index f29028148806..a46d6ad9ef0a 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -2666,11 +2666,11 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
>   				"Bypassing cpu_cache_invalidate_memregion() for testing!\n");
>   			clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags);
>   			return 0;
> -		} else {
> -			dev_err(&cxlr->dev,
> -				"Failed to synchronize CPU cache state\n");
> -			return -ENXIO;
>   		}
> +
> +		dev_err(&cxlr->dev,
> +			"Failed to synchronize CPU cache state\n");
> +		return -ENXIO;
>   	}
>   
>   	cpu_cache_invalidate_memregion(IORES_DESC_CXL);