linux-kernel - Re: [linus:master] [x86] adfcf4231b: blogbench.read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=whLZUauRc3skOQGqm3WW4Hr711jHU90dO23ySPFDOFpRA@mail.gmail.com>
Date:   Tue, 9 May 2023 10:05:01 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Feng Tang <feng.tang@...el.com>
Cc:     kernel test robot <yujie.liu@...el.com>,
        Frank Denis <j@...eftpd.org>, oe-lkp@...ts.linux.dev,
        lkp@...el.com, linux-kernel@...r.kernel.org, ying.huang@...el.com,
        fengwei.yin@...el.com
Subject: Re: [linus:master] [x86] adfcf4231b: blogbench.read_score -10.9% regression

On Tue, May 9, 2023 at 5:30 AM Feng Tang <feng.tang@...el.com> wrote:
>
> > At a *minimum* that benchmark should have different threads using
> > different read() buffers.
>
> We tried a debug patch which allocates a dedicated buffer for
> each reader thread, run it on the same Cacade Lake platform, and
> the regression is _gone_, after the noise of cache false sharing is
> reduced.

Thanks for verifying.

I was pretty sure that was the issue, but it's always good to
double-check that there wasn't something else going on,

                 Linus