linux-kernel - Re: [PATCH blktests v3 10/12] nvme/rc: Calculate IO size for random fio jobs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vlq7hqrweo527daqh7m5iidcvlhujxsc3hwmeqm2oen4dbucsa@3yo2lm3d6aap>
Date:   Wed, 10 May 2023 19:14:21 +0200
From:   Daniel Wagner <dwagner@...e.de>
To:     Shinichiro Kawasaki <shinichiro.kawasaki@....com>
Cc:     "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Shin'ichiro Kawasaki <shinichiro@...tmail.com>,
        Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH blktests v3 10/12] nvme/rc: Calculate IO size for random
 fio jobs

On Sun, May 07, 2023 at 11:31:10PM +0000, Shinichiro Kawasaki wrote:
 > -	_xfs_run_fio_verify_io /dev/"${nvmedev}n1" "1m" || echo FAIL
> > +	rand_io_size="$(_nvme_calc_rand_io_size 4M)"
> > +	_run_fio_rand_io --filename="/dev/${nvmedev}n1" --size="${rand_io_size}"
> 
> Here, _xfs_run_fio_verify_io is replaced with _run_fio_rand_io. May I confirm
> that this replacement does not affect this test case? Same question for the hunk
> below.

This is on purpose. The test just wants only verify that IO is still working.
Because _xfs_run_fio_verify_io has the minimum requirement of 350M for
nvme_img_size. When I wrote the test I didn't know this and thus this change.

I'll update the commit message to include this info.