[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0e13efbf-9a48-6e70-fdf3-8290f28c6dc7@189.cn>
Date: Thu, 11 May 2023 02:20:31 +0800
From: Sui Jingfeng <15330273260@....cn>
To: Thomas Zimmermann <tzimmermann@...e.de>, deller@....de,
geert@...ux-m68k.org, javierm@...hat.com, daniel@...ll.ch,
vgupta@...nel.org, chenhuacai@...nel.org, kernel@...0n.name,
davem@...emloft.net, James.Bottomley@...senPartnership.com,
arnd@...db.de, sam@...nborg.org
Cc: linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-arch@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-ia64@...r.kernel.org,
loongarch@...ts.linux.dev, linux-m68k@...ts.linux-m68k.org,
sparclinux@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-parisc@...r.kernel.org
Subject: Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces
Hi, Thomas
I love your patch, yet something to improve:
On 2023/5/10 19:05, Thomas Zimmermann wrote:
> Fix coding style. No functional changes.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
> Reviewed-by: Arnd Bergmann <arnd@...db.de>
> Reviewed-by: Sam Ravnborg <sam@...nborg.org>
> Reviewed-by: Sui Jingfeng <suijingfeng@...ngson.cn>
> Tested-by: Sui Jingfeng <suijingfeng@...ngson.cn>
> ---
> drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++---
> drivers/video/fbdev/matrox/matroxfb_base.h | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/fbdev/matrox/matroxfb_accel.c b/drivers/video/fbdev/matrox/matroxfb_accel.c
> index 9cb0685feddd..ce51227798a1 100644
> --- a/drivers/video/fbdev/matrox/matroxfb_accel.c
> +++ b/drivers/video/fbdev/matrox/matroxfb_accel.c
> @@ -88,7 +88,7 @@
>
> static inline void matrox_cfb4_pal(u_int32_t* pal) {
> unsigned int i;
> -
> +
> for (i = 0; i < 16; i++) {
> pal[i] = i * 0x11111111U;
> }
> @@ -96,7 +96,7 @@ static inline void matrox_cfb4_pal(u_int32_t* pal) {
>
> static inline void matrox_cfb8_pal(u_int32_t* pal) {
> unsigned int i;
> -
> +
> for (i = 0; i < 16; i++) {
> pal[i] = i * 0x01010101U;
> }
> @@ -482,7 +482,7 @@ static void matroxfb_1bpp_imageblit(struct matrox_fb_info *minfo, u_int32_t fgx,
> /* Tell... well, why bother... */
> while (height--) {
> size_t i;
> -
> +
> for (i = 0; i < step; i += 4) {
> /* Hope that there are at least three readable bytes beyond the end of bitmap */
> fb_writel(get_unaligned((u_int32_t*)(chardata + i)),mmio.vaddr);
> diff --git a/drivers/video/fbdev/matrox/matroxfb_base.h b/drivers/video/fbdev/matrox/matroxfb_base.h
> index 958be6805f87..c93c69bbcd57 100644
> --- a/drivers/video/fbdev/matrox/matroxfb_base.h
> +++ b/drivers/video/fbdev/matrox/matroxfb_base.h
> @@ -301,9 +301,9 @@ struct matrox_altout {
> int (*verifymode)(void* altout_dev, u_int32_t mode);
> int (*getqueryctrl)(void* altout_dev,
> struct v4l2_queryctrl* ctrl);
Noticed that there are plenty of coding style problems in matroxfb_base.h,
why you only fix a few of them? Take this two line as an example,
shouldn't
they be fixed also as following?
int (*verifymode)(void *altout_dev, u_int32_t mode);
int (*getqueryctrl)(void *altout_dev,
struct v4l2_queryctrl *ctrl);
> - int (*getctrl)(void* altout_dev,
> + int (*getctrl)(void *altout_dev,
> struct v4l2_control* ctrl);
> - int (*setctrl)(void* altout_dev,
> + int (*setctrl)(void *altout_dev,
> struct v4l2_control* ctrl);
> };
>
Powered by blists - more mailing lists