linux-kernel - Re: [PATCH v5 1/2] cxl/mbox: Remove redundant dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <645c144483244_91698294ac@iweiny-mobl.notmuch>
Date:   Wed, 10 May 2023 15:01:40 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     Raghu Halharvi <raghuhack78@...il.com>,
        <linux-cxl@...r.kernel.org>,
        Alison Schofield <alison.schofield@...el.com>,
        <ira.weiny@...el.com>, <bwidawsk@...nel.org>,
        <dan.j.williams@...el.com>, <vishal.l.verma@...el.com>
CC:     <linux-kernel@...r.kernel.org>, Dave Jiang <dave.jiang@...el.com>
Subject: Re: [PATCH v5 1/2] cxl/mbox: Remove redundant dev_err() after failed
 mem alloc

Raghu Halharvi wrote:
> Issue found with checkpatch
> 
> A return of errno should be good enough if the memory allocation fails,
> the error message here is redundant as per the coding style, removing it.
> 
> Reviewed-by: Vishal Verma <vishal.l.verma@...el.com>
> Reviewed-by: Dave Jiang <dave.jiang@...el.com>

Reviewed-by: Ira Weiny <ira.weiny@...el.com>

> Signed-off-by: Raghu Halharvi <raghuhack78@...il.com>
> ---
>  drivers/cxl/core/mbox.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index f2addb457172..11ea145b4b1f 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -1112,10 +1112,8 @@ struct cxl_dev_state *cxl_dev_state_create(struct device *dev)
>  	struct cxl_dev_state *cxlds;
>  
>  	cxlds = devm_kzalloc(dev, sizeof(*cxlds), GFP_KERNEL);
> -	if (!cxlds) {
> -		dev_err(dev, "No memory available\n");
> +	if (!cxlds)
>  		return ERR_PTR(-ENOMEM);
> -	}
>  
>  	mutex_init(&cxlds->mbox_mutex);
>  	mutex_init(&cxlds->event.log_lock);
> -- 
> 2.39.2
>