linux-kernel - Re: [PATCH v3 3/6] serial: 8250: Add dl_read/write, bugs and mapsize into plat_serial8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b9e29856-69a4-007c-930a-87e05b82eaf8@kernel.org>
Date:   Wed, 10 May 2023 07:55:26 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        linux-serial@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philippe Mathieu-Daudé <philmd@...aro.org>,
        linux-kernel@...r.kernel.org
Cc:     Niklas Schnelle <schnelle@...ux.ibm.com>
Subject: Re: [PATCH v3 3/6] serial: 8250: Add dl_read/write, bugs and mapsize
 into plat_serial8250_port

On 09. 05. 23, 13:39, Ilpo Järvinen wrote:
> Add mapsize, bugs, and divisor latch read/write functions
> (->dl_read/write()) into plat_serial8250_port to carry the setup
> necessary for RT288x/Au1xxx devices over to uart port.
> 
> Document the added members with kerneldoc style but do not enable
> kerneldoc yet as there are many fields which remain undocumented.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

> --- a/include/linux/serial_8250.h
> +++ b/include/linux/serial_8250.h
...
> @@ -28,8 +44,11 @@ struct plat_serial8250_port {
>   	unsigned char	has_sysrq;	/* supports magic SysRq */
>   	unsigned int	type;		/* If UPF_FIXED_TYPE */
>   	upf_t		flags;		/* UPF_* flags */
> +	unsigned short	bugs;		/* port bugs */

I would suggest u16 for bitfields like this. (Or DECLARE_BITMAP, but 
that would unnecessarily eat a long.)

thanks,
-- 
js
suse labs