linux-kernel - [PATCH 0/2] Reworking configurability of X86_FEATURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 May 2023 08:57:11 +0200
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H . Peter Anvin" <hpa@...or.com>
Cc:     Masahiro Yamada <masahiroy@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Subject: [PATCH 0/2] Reworking configurability of X86_FEATURE_NAMES

Dear Dave, dear Boris, dear x86 maintainers,

as follow-up to the discussion on my initial patch on changing the
visibility of X86_FEATURE_NAMES (see Link), here are two patches:

Patch 1 simply makes the minimal one-line change to make X86_FEATURE_NAMES
disappear from the prompt.

Patch 2 is the more radical change to remove the whole config and see which
code would generally be impacted; just as quick exploration.

The diffstat shows we are getting rid of a bit of code throughout arch/x86,
but the change and reduction is not too complex either:

 arch/x86/Kconfig                  | 12 ------------
 arch/x86/Kconfig.cpu              |  2 +-
 arch/x86/boot/Makefile            |  2 --
 arch/x86/boot/cpu.c               | 13 -------------
 arch/x86/include/asm/cpufeature.h |  5 -----
 arch/x86/kernel/cpu/Makefile      |  4 +---
 arch/x86/kernel/cpu/common.c      |  4 ----
 7 files changed, 2 insertions(+), 40 deletions(-)

Probably, you just want to pick patch 1 and wait for any complaints. Or if
you are confident the compliants will not show up, simply apply both.

Otherwise, I will put it on my list to come back in a year or two, and if
there were no complaints till then, provide the updated patch to remove the
X86_FEATURE_NAMES config then.

Link: https://lore.kernel.org/all/20230509084007.24373-1-lukas.bulwahn@gmail.com/

Best regards,

Lukas

Lukas Bulwahn (2):
  x86: make X86_FEATURE_NAMES non-configurable in prompt
  x86: always build with X86_FEATURE_NAMES functionality

 arch/x86/Kconfig                  | 12 ------------
 arch/x86/Kconfig.cpu              |  2 +-
 arch/x86/boot/Makefile            |  2 --
 arch/x86/boot/cpu.c               | 13 -------------
 arch/x86/include/asm/cpufeature.h |  5 -----
 arch/x86/kernel/cpu/Makefile      |  4 +---
 arch/x86/kernel/cpu/common.c      |  4 ----
 7 files changed, 2 insertions(+), 40 deletions(-)

-- 
2.17.1