linux-kernel - Re: [PATCH 2/2] PCI: rcar-host: add support for optional regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 May 2023 09:46:41 +0200
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-renesas-soc@...r.kernel.org,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] PCI: rcar-host: add support for optional regulators


> > +       int i, err;
> 
> unsigned int i?

OK.

> 
> >         struct pci_host_bridge *bridge;
> 
> The (lack of) reverse-Xmas-tree ordering is hurting my OCD, but that's
> not your fault...

Ack :) I can change it, though.

> > +                       dev_err_probe(dev, err, "error enabling regulator %s\n",
> > +                                     rcar_pcie_supplies[i]);
> 
> Shouldn't this return, and propagate the error code upstream?

Ouch, brown paper bag, please.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)