linux-kernel - Re: [PATCH] ALSA: PCM: Fix codestyle issues in pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1a912ea-884b-fdcd-1c05-87089f1e97b7@gmail.com>
Date:   Wed, 10 May 2023 11:55:18 +0400
From:   Ivan Orlov <ivan.orlov0322@...il.com>
To:     ivan.orlov0322@...il.com
Cc:     perex@...ex.cz, tiwai@...e.com, oswald.buddenhagen@....de,
        axboe@...nel.dk, 42.hyeyoo@...il.com, surenb@...gle.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] ALSA: PCM: Fix codestyle issues in pcm_native.c

On 5/10/23 11:48, Greg KH wrote:
> - Your patch did many different things all at once, making it difficult
>    to review.  All Linux kernel patches need to only do one thing at a
>    time.  If you need to do multiple things (such as clean up all coding
>    style issues in a file/driver), do it in a sequence of patches, each
>    one doing only one thing.  This will make it easier to review the
>    patches to ensure that they are correct, and to help alleviate any
>    merge issues that larger patches can cause.
> 
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.
> 
> thanks,
> 
> greg k-h's patch email bot

Greg's Bot is right, it will be better as a sequence of patches. Sorry 
for bothering!

Kind regards,
Ivan Orlov.