linux-kernel - Re: [PATCH net-next v1 2/2] net: remove __skb_frag_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZFtS1zfi+zrI0KJu@corigine.com>
Date:   Wed, 10 May 2023 10:16:23 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc:     Yunsheng Lin <linyunsheng@...wei.com>, davem@...emloft.net,
        kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v1 2/2] net: remove __skb_frag_set_page()

On Tue, May 09, 2023 at 04:49:46PM -0700, Jesse Brandeburg wrote:
> On 5/9/2023 4:46 AM, Yunsheng Lin wrote:
> > The remaining users calling __skb_frag_set_page() with
> > page being NULL seems to be doing defensive programming,
> > as shinfo->nr_frags is already decremented, so remove
> > them.
> > 
> > Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>
> > ---
> > RFC: remove a local variable as pointed out by Simon.
> 
> Makes sense.
> 
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 
> CC: Simon

Thanks Yunsheng and Jessee,

this looks good to me.

Reviewed-by: Simon Horman <simon.horman@...igine.com>