linux-kernel - Re: [PATCH] ALSA: PCM: Fix codestyle issues in pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875y905zr7.wl-tiwai@suse.de>
Date:   Wed, 10 May 2023 10:58:36 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Oswald Buddenhagen <oswald.buddenhagen@....de>
Cc:     Ivan Orlov <ivan.orlov0322@...il.com>, perex@...ex.cz,
        tiwai@...e.com, axboe@...nel.dk, 42.hyeyoo@...il.com,
        surenb@...gle.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] ALSA: PCM: Fix codestyle issues in pcm_native.c

On Wed, 10 May 2023 10:21:08 +0200,
Oswald Buddenhagen wrote:
> 
> On Wed, May 10, 2023 at 10:06:16AM +0200, Takashi Iwai wrote:
> > Also, if it's only about white space fix or some indent level issues,
> > that could be rather more noise and disturbs the git change history,
> > e.g. it makes difficult to find out the real code changes via git
> > blame, especially it touches a huge amount of lines like this.
> > 
> > That said, I'm not going to take such "coding style cleanup" patch
> > blindly.  If it's associated with other real fix or enhancement, I'll
> > happily take it.  Otherwise, I'd rather leave it.
> > 
> a maybe less confusing way to put it would be "do whitespace cleanups
> only on the lines that contain "real" changes, and maybe in their
> immediate proximity for consistency". that means that whitespace-only
> patches are by definition not acceptable.

Not only that, it's surely acceptable as a preliminary work for other
patches, for example, too.  Also, if the existing code is really ugly,
we can clean up, of course.

But majority of such whitespace fix patches have been just because
patchwork complains, and that's no right reason.


Takashi