linux-kernel - Re: [PATCH] mm: memory_hotplug: Fix format string in __add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 May 2023 11:02:40 +0200
From:   Rick Wertenbroek <rick.wertenbroek@...il.com>
To:     rick.wertenbroek@...g-vd.ch
Cc:     David Hildenbrand <david@...hat.com>,
        Oscar Salvador <osalvador@...e.de>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: memory_hotplug: Fix format string in __add_pages warning

On Wed, May 10, 2023 at 10:47 AM Rick Wertenbroek
<rick.wertenbroek@...il.com> wrote:
>
> The format string has a typo and prints e.g.,
> "Misaligned __add_pages start: 0xfc605 end: #fc609" instead
> of "Misaligned __add_pages start: 0xfc605 end: 0xfc609"
> Fix "#%lx" => "%#lx"
>
> Signed-off-by: Rick Wertenbroek <rick.wertenbroek@...il.com>

The issue appears in the __remove_pages format string as well,
sorry didn't notice that right away. I'll send a new patch.

Rick
> ---
>  mm/memory_hotplug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 8e0fa209d533..446abb088b51 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -325,7 +325,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
>         }
>
>         if (check_pfn_span(pfn, nr_pages)) {
> -               WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1);
> +               WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1);
>                 return -EINVAL;
>         }
>
> --
> 2.25.1
>