linux-kernel - Re: [PATCH v2] phy: cadence: Sierra: Add single link SGMII register configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230510093447.6hwro4ukv6i2dzve@pengutronix.de>
Date:   Wed, 10 May 2023 11:34:47 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Marcin Wierzbicki <mawierzb@...co.com>
Cc:     Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Roger Quadros <rogerq@...nel.org>,
        Swapnil Jakhade <sjakhade@...ence.com>,
        linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org,
        xe-linux-external@...co.com, danielwa@...co.com, olicht@...co.com,
        Bartosz Wawrzyniak <bwawrzyn@...co.com>
Subject: Re: [PATCH v2] phy: cadence: Sierra: Add single link SGMII register
 configuration

Hello,

On Mon, May 08, 2023 at 04:01:40PM +0000, Marcin Wierzbicki wrote:
> Add single link SGMII register configuration for no SSC for
> cdns,sierra-phy-t0 compatibility string.
> The configuration is based on Sierra Programmer's Guide and
> validated in Cisco CrayAR SoC.
> 
> Co-developed-by: Bartosz Wawrzyniak <bwawrzyn@...co.com>
> Signed-off-by: Bartosz Wawrzyniak <bwawrzyn@...co.com>
> Signed-off-by: Marcin Wierzbicki <mawierzb@...co.com>
> Change-Id: Id4c093a1bbf409f3176736b5326854a1396391c1

The Change-Id footers are not supposed to appear in the kernel's
history, so it's better to leave them out when submitting a patch.

(I didn't look at the remaining patch, so me not criticizing more
doesn't implicitly mean the rest is fine. (But of course it also doesn't
mean it is not fine.))

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)