linux-kernel - Re: [net-next PATCH] macsec: Use helper macsec_netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZFtyF3SqLCQleCZy@corigine.com>
Date:   Wed, 10 May 2023 12:29:43 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Subbaraya Sundeep <sbhatta@...vell.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, saeedm@...dia.com, tariqt@...dia.com,
        roid@...dia.com, leon@...nel.org, maxtram95@...il.com,
        kliteyn@...dia.com, irusskikh@...vell.com, liorna@...dia.com,
        ehakim@...dia.com, dbogdanov@...vell.com, sd@...asysnail.net,
        sgoutham@...vell.com, gakula@...vell.com, naveenm@...vell.com,
        hkelam@...vell.com, lcherian@...vell.com
Subject: Re: [net-next PATCH] macsec: Use helper macsec_netdev_priv for
 offload drivers

On Wed, May 10, 2023 at 01:58:09PM +0530, Subbaraya Sundeep wrote:
> Now macsec on top of vlan can be offloaded to macsec offloading
> devices so that VLAN tag is sent in clear text on wire i.e,
> packet structure is DMAC|SMAC|VLAN|SECTAG. Offloading devices can
> simply enable NETIF_F_HW_MACSEC feature in netdev->vlan_features for
> this to work. But the logic in offloading drivers to retrieve the
> private structure from netdev needs to be changed to check whether
> the netdev received is real device or a vlan device and get private
> structure accordingly. This patch changes the offloading drivers to
> use helper macsec_netdev_priv instead of netdev_priv.
> 
> Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>