linux-kernel - Re: [PATCH 6.1 000/610] 6.1.28-rc2 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZFuZllSJguONF2p0@Air-de-Roger>
Date:   Wed, 10 May 2023 15:18:14 +0200
From:   Roger Pau Monné <roger.pau@...rix.com>
To:     Pavel Machek <pavel@...x.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>, seanga2@...il.com,
        stable@...r.kernel.org, patches@...ts.linux.dev,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
        patches@...nelci.org, lkft-triage@...ts.linaro.org,
        jonathanh@...dia.com, f.fainelli@...il.com,
        sudipm.mukherjee@...il.com, srw@...dewatkins.net, rwarsow@....de
Subject: Re: [PATCH 6.1 000/610] 6.1.28-rc2 review

On Wed, May 10, 2023 at 01:48:49PM +0200, Pavel Machek wrote:
> Hi!
> 
> > This is the start of the stable review cycle for the 6.1.28 release.
> > There are 610 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> 
> 
> > Sean Anderson <seanga2@...il.com>
> >     net: sunhme: Fix uninitialized return code
> 
> This one is wrong for stable. err is still initialzied to 0, which is
> wrong thing to do. Mainline is ok, but fix does not work for 6.1.
> 
> > Roger Pau Monne <roger.pau@...rix.com>
> >     ACPI: processor: Fix evaluating _PDC method when running as Xen dom0
> 
> If the condition can be handled (and code has "return false"), it
> should use WARN, not BUG.

Feel free to send a followup fix.

Such dummy handler getting caller is a sign of an error elsewhere:
someone playing with Kconfig logic or trying to add _PDC / Xen support
to a different architecture, so I think it's fine to BUG in that
case.

Thanks, Roger.