| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 May 2023 06:24:16 -0700
From: "Paul E. McKenney" <paulmck@...nel.org>
To: kernel test robot <lkp@...el.com>
Cc: "Uladzislau Rezki (Sony)" <urezki@...il.com>,
oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
"Joel Fernandes (Google)" <joel@...lfernandes.org>
Subject: Re: [paulmck-rcu:dev.2023.05.08c 15/67]
drivers/infiniband/sw/rxe/rxe_verbs.c:1359:21: error: macro "kfree_rcu"
requires 2 arguments, but only 1 given
On Wed, May 10, 2023 at 09:59:31AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2023.05.08c
> head: b7c6d563fb2aa29acb91fd8665380979bb8d131d
> commit: df2d6f48c0dc148ea5dc86d3264ac27bd908b1e5 [15/67] rcu/kvfree: Eliminate k[v]free_rcu() single argument macro
> config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230510/202305100912.lreD3oLd-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?id=df2d6f48c0dc148ea5dc86d3264ac27bd908b1e5
> git remote add paulmck-rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
> git fetch --no-tags paulmck-rcu dev.2023.05.08c
> git checkout df2d6f48c0dc148ea5dc86d3264ac27bd908b1e5
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@...el.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202305100912.lreD3oLd-lkp@intel.com/
>
> Note: the paulmck-rcu/dev.2023.05.08c HEAD b7c6d563fb2aa29acb91fd8665380979bb8d131d builds fine.
> It only hurts bisectability.
The final fixes eliminating the need for single-argument kfree_rcu()
are not yet in mainline, so I revert this commit further up the stack
for my own testing. Once all the fixes make it into -next, I will leave
that revert out of -next testing in order to help prevent additional
uses from sneaking in. ;-)
Thanx, Paul
> All errors (new ones prefixed by >>):
>
> drivers/infiniband/sw/rxe/rxe_verbs.c: In function 'rxe_dereg_mr':
> >> drivers/infiniband/sw/rxe/rxe_verbs.c:1359:21: error: macro "kfree_rcu" requires 2 arguments, but only 1 given
> 1359 | kfree_rcu(mr);
> | ^
> In file included from include/linux/rculist.h:11,
> from include/linux/pid.h:5,
> from include/linux/sched.h:14,
> from include/linux/ratelimit.h:6,
> from include/linux/dev_printk.h:16,
> from include/linux/device.h:15,
> from include/linux/dma-mapping.h:7,
> from drivers/infiniband/sw/rxe/rxe_verbs.c:7:
> include/linux/rcupdate.h:961: note: macro "kfree_rcu" defined here
> 961 | #define kfree_rcu(ptr, rhf) kvfree_rcu_arg_2(ptr, rhf)
> |
> >> drivers/infiniband/sw/rxe/rxe_verbs.c:1359:9: error: 'kfree_rcu' undeclared (first use in this function); did you mean 'kfree_skb'?
> 1359 | kfree_rcu(mr);
> | ^~~~~~~~~
> | kfree_skb
> drivers/infiniband/sw/rxe/rxe_verbs.c:1359:9: note: each undeclared identifier is reported only once for each function it appears in
>
>
> vim +/kfree_rcu +1359 drivers/infiniband/sw/rxe/rxe_verbs.c
>
> 8700e3e7c4857d Moni Shoua 2016-06-16 1342
> 5bf944f24129cb Bob Pearson 2023-03-03 1343 static int rxe_dereg_mr(struct ib_mr *ibmr, struct ib_udata *udata)
> 5bf944f24129cb Bob Pearson 2023-03-03 1344 {
> 5bf944f24129cb Bob Pearson 2023-03-03 1345 struct rxe_mr *mr = to_rmr(ibmr);
> 5bf944f24129cb Bob Pearson 2023-03-03 1346 int err, cleanup_err;
> 5bf944f24129cb Bob Pearson 2023-03-03 1347
> 5bf944f24129cb Bob Pearson 2023-03-03 1348 /* See IBA 10.6.7.2.6 */
> 5bf944f24129cb Bob Pearson 2023-03-03 1349 if (atomic_read(&mr->num_mw) > 0) {
> 5bf944f24129cb Bob Pearson 2023-03-03 1350 err = -EINVAL;
> 5bf944f24129cb Bob Pearson 2023-03-03 1351 rxe_dbg_mr(mr, "mr has mw's bound");
> 5bf944f24129cb Bob Pearson 2023-03-03 1352 goto err_out;
> 5bf944f24129cb Bob Pearson 2023-03-03 1353 }
> 5bf944f24129cb Bob Pearson 2023-03-03 1354
> 5bf944f24129cb Bob Pearson 2023-03-03 1355 cleanup_err = rxe_cleanup(mr);
> 5bf944f24129cb Bob Pearson 2023-03-03 1356 if (cleanup_err)
> 5bf944f24129cb Bob Pearson 2023-03-03 1357 rxe_err_mr(mr, "cleanup failed, err = %d", cleanup_err);
> 5bf944f24129cb Bob Pearson 2023-03-03 1358
> 5bf944f24129cb Bob Pearson 2023-03-03 @1359 kfree_rcu(mr);
> 5bf944f24129cb Bob Pearson 2023-03-03 1360 return 0;
> 5bf944f24129cb Bob Pearson 2023-03-03 1361
> 5bf944f24129cb Bob Pearson 2023-03-03 1362 err_out:
> 5bf944f24129cb Bob Pearson 2023-03-03 1363 rxe_err_mr(mr, "returned err = %d", err);
> 5bf944f24129cb Bob Pearson 2023-03-03 1364 return err;
> 5bf944f24129cb Bob Pearson 2023-03-03 1365 }
> 5bf944f24129cb Bob Pearson 2023-03-03 1366
>
> :::::: The code at line 1359 was first introduced by commit
> :::::: 5bf944f24129cbc4b5828348bdce2db94ca9fbd6 RDMA/rxe: Add error messages
>
> :::::: TO: Bob Pearson <rpearsonhpe@...il.com>
> :::::: CC: Jason Gunthorpe <jgg@...dia.com>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests
Powered by blists - more mailing lists