linux-kernel - Re: [PATCH bpf-next] arm64,bpf: Support struct arguments in the BPF trampoline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABRcYmK_J83T6C+9tqaQ1R5BfQ0D7FQQDFK5h7_UwBEcbu2QsQ@mail.gmail.com>
Date:   Wed, 10 May 2023 15:53:58 +0200
From:   Florent Revest <revest@...omium.org>
To:     Xu Kuohai <xukuohai@...wei.com>
Cc:     bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        KP Singh <kpsingh@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Xu Kuohai <xukuohai@...weicloud.com>,
        Zi Shen Lim <zlim.lnx@...il.com>
Subject: Re: [PATCH bpf-next] arm64,bpf: Support struct arguments in the BPF trampoline

On Wed, May 10, 2023 at 9:07 AM Xu Kuohai <xukuohai@...wei.com> wrote:
>
> On 5/9/2023 12:46 AM, Florent Revest wrote:
> > @@ -1799,7 +1799,7 @@ static int prepare_trampoline(struct jit_ctx *ctx, struct bpf_tramp_image *im,
> >        *                  [ ...               ]
> >        * SP + args_off    [ arg1              ]
> >        *
> > -      * SP + nargs_off   [ args count        ]
> > +      * SP + nregs_off   [ arg regs count    ]
>
> For description consistency, should arg1 ... argN in the previous
> lines also be changed to arg reg 1 ... arg reg N?

Sure, sounds good :) I'll send a v2

(for some reason your email ended up in my spam folder, lucky I noticed it)