linux-kernel - Re: [PATCH 14/23] riscv/hugetlb: pte_alloc_huge() pte_offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-fa58638c-1b42-4264-8bf1-55d4bc42a5e2@palmer-ri-x1c9>
Date:   Wed, 10 May 2023 07:01:54 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     hughd@...gle.com
CC:     akpm@...ux-foundation.org, mike.kravetz@...cle.com,
        rppt@...nel.org, kirill.shutemov@...ux.intel.com,
        willy@...radead.org, david@...hat.com, surenb@...gle.com,
        zhengqi.arch@...edance.com, linux@...linux.org.uk,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, geert@...ux-m68k.org,
        gerg@...ux-m68k.org, monstr@...str.eu, tsbogend@...ha.franken.de,
        deller@....de, dave.anglin@...l.net, aneesh.kumar@...ux.ibm.com,
        mpe@...erman.id.au, alexghiti@...osinc.com, hca@...ux.ibm.com,
        borntraeger@...ux.ibm.com, imbrenda@...ux.ibm.com,
        glaubitz@...sik.fu-berlin.de, davem@...emloft.net,
        chris@...kel.net, jcmvbkbc@...il.com, x86@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-ia64@...r.kernel.org,
        linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org,
        linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org,
        linux-sh@...r.kernel.org, sparclinux@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject:     Re: [PATCH 14/23] riscv/hugetlb: pte_alloc_huge() pte_offset_huge()

On Tue, 09 May 2023 21:59:57 PDT (-0700), hughd@...gle.com wrote:
> pte_alloc_map() expects to be followed by pte_unmap(), but hugetlb omits
> that: to keep balance in future, use the recently added pte_alloc_huge()
> instead; with pte_offset_huge() a better name for pte_offset_kernel().
>
> Signed-off-by: Hugh Dickins <hughd@...gle.com>
> ---
>  arch/riscv/mm/hugetlbpage.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/mm/hugetlbpage.c b/arch/riscv/mm/hugetlbpage.c
> index a163a3e0f0d4..80926946759f 100644
> --- a/arch/riscv/mm/hugetlbpage.c
> +++ b/arch/riscv/mm/hugetlbpage.c
> @@ -43,7 +43,7 @@ pte_t *huge_pte_alloc(struct mm_struct *mm,
>
>  	for_each_napot_order(order) {
>  		if (napot_cont_size(order) == sz) {
> -			pte = pte_alloc_map(mm, pmd, addr & napot_cont_mask(order));
> +			pte = pte_alloc_huge(mm, pmd, addr & napot_cont_mask(order));
>  			break;
>  		}
>  	}
> @@ -90,7 +90,7 @@ pte_t *huge_pte_offset(struct mm_struct *mm,
>
>  	for_each_napot_order(order) {
>  		if (napot_cont_size(order) == sz) {
> -			pte = pte_offset_kernel(pmd, addr & napot_cont_mask(order));
> +			pte = pte_offset_huge(pmd, addr & napot_cont_mask(order));
>  			break;
>  		}
>  	}

Acked-by: Palmer Dabbelt <palmer@...osinc.com>