linux-kernel - Re: [PATCH] mmc: mediatek: Avoid ugly error message when SDIO wakeup IRQ isn't used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <423c7e0b-95d7-8389-02fc-6dd5ef215e93@gmail.com>
Date:   Wed, 10 May 2023 16:19:19 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Douglas Anderson <dianders@...omium.org>,
        Chaotian Jing <chaotian.jing@...iatek.com>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Yong Mao <yong.mao@...iatek.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, linux-mmc@...r.kernel.org
Subject: Re: [PATCH] mmc: mediatek: Avoid ugly error message when SDIO wakeup
 IRQ isn't used



On 10/05/2023 15:44, Douglas Anderson wrote:
> When I boot a kukui-kodama board, I see an ugly warning in my kernel
> log:
>    mtk-msdc 11240000.mmc: error -ENXIO: IRQ sdio_wakeup not found
> 
> It's pretty normal not to have an "sdio_wakeup" IRQ defined. In fact,
> no device trees in mainline seem to have it. Let's use the
> platform_get_irq_byname_optional() to avoid the error message.
> 
> Fixes: 527f36f5efa4 ("mmc: mediatek: add support for SDIO eint wakup IRQ")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> ---
> 
>   drivers/mmc/host/mtk-sd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index edade0e54a0c..8ce864169986 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2707,7 +2707,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
>   
>   	/* Support for SDIO eint irq ? */
>   	if ((mmc->pm_caps & MMC_PM_WAKE_SDIO_IRQ) && (mmc->pm_caps & MMC_PM_KEEP_POWER)) {
> -		host->eint_irq = platform_get_irq_byname(pdev, "sdio_wakeup");
> +		host->eint_irq = platform_get_irq_byname_optional(pdev, "sdio_wakeup");
>   		if (host->eint_irq > 0) {
>   			host->pins_eint = pinctrl_lookup_state(host->pinctrl, "state_eint");
>   			if (IS_ERR(host->pins_eint)) {