linux-kernel - Re: [PATCH] fs/coredump: open coredump file in O_WRONLY instead of O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14af0872-a7c2-0aab-b21d-189af055f528@yandex-team.ru>
Date:   Wed, 10 May 2023 18:15:41 +0300
From:   Vladimir Sementsov-Ogievskiy <vsementsov@...dex-team.ru>
To:     Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        ptikhomirov@...tuozzo.com, Andrey Ryabinin <arbn@...dex-team.com>
Subject: Re: [PATCH] fs/coredump: open coredump file in O_WRONLY instead of
 O_RDWR

Gently ping.

Is there any interest?

On 20.04.23 15:04, Vladimir Sementsov-Ogievskiy wrote:
> This makes it possible to make stricter apparmor profile and don't
> allow the program to read any coredump in the system.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@...dex-team.ru>
> ---
>   fs/coredump.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/coredump.c b/fs/coredump.c
> index 5df1e6e1eb2b..8f263a389175 100644
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -646,7 +646,7 @@ void do_coredump(const kernel_siginfo_t *siginfo)
>   	} else {
>   		struct mnt_idmap *idmap;
>   		struct inode *inode;
> -		int open_flags = O_CREAT | O_RDWR | O_NOFOLLOW |
> +		int open_flags = O_CREAT | O_WRONLY | O_NOFOLLOW |
>   				 O_LARGEFILE | O_EXCL;
>   
>   		if (cprm.limit < binfmt->min_coredump)

-- 
Best regards,
Vladimir