linux-kernel - Re: [PATCH] string: use __builtin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAG_fn=VgkA0OdjqJg1FCBX5FcXtm96h9PTTTwAt3qWa0n0oNyw@mail.gmail.com>
Date:   Wed, 10 May 2023 18:07:44 +0200
From:   Alexander Potapenko <glider@...gle.com>
To:     Kees Cook <keescook@...omium.org>, akpm@...ux-foundation.org
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org, elver@...gle.com,
        dvyukov@...gle.com, kasan-dev@...glegroups.com, andy@...nel.org,
        ndesaulniers@...gle.com, nathan@...nel.org
Subject: Re: [PATCH] string: use __builtin_memcpy() in strlcpy/strlcat

On Wed, May 10, 2023 at 9:48 AM Alexander Potapenko <glider@...gle.com> wrote:
>
>
>
> On Fri, Apr 28, 2023 at 3:48 PM Alexander Potapenko <glider@...gle.com> wrote:
>>

>> > I *think* this isn't a problem for CONFIG_FORTIFY, since these will be
>> > replaced and checked separately -- but it still seems strange that you
>> > need to explicitly use __builtin_memcpy.
>>
>
> Or did you mean we'd better use __underlying_memcpy() here instead? I am a bit puzzled.

Kees told me offline that the patch in question is fine.
@Andrew, would it be possible to queue it for 6.4?

--
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Paul Manicle, Liana Sebastian
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg