linux-kernel - Re: [PATCH v1 2/2] dt-bindings: mfd: add bindings for AXP192 MFD device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230510-rage-amazingly-d090d1e838f0@spud>
Date:   Wed, 10 May 2023 17:39:59 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Aidan MacDonald <aidanmacdonald.0x0@...il.com>
Cc:     lee@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        wens@...e.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] dt-bindings: mfd: add bindings for AXP192 MFD
 device

On Wed, May 10, 2023 at 04:15:42PM +0100, Aidan MacDonald wrote:
> The AXP192 is another X-Powers PMIC similar to the existing ones.

In the driver patch the commit message says:
| The AXP192 PMIC is similar to the AXP202/AXP209, but with different
| regulators, additional GPIOs, and a different IRQ register layout.

That'd be nice to have in the commit message here too, to explain why
you're adding to the enum rather than listing a fallback.
Otherwise,
Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

> 
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@...il.com>
> ---
>  Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> index f7f0f2c0421a..9ad55746133b 100644
> --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> @@ -90,6 +90,7 @@ properties:
>      oneOf:
>        - enum:
>            - x-powers,axp152
> +          - x-powers,axp192
>            - x-powers,axp202
>            - x-powers,axp209
>            - x-powers,axp221
> -- 
> 2.39.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)