linux-kernel - RE: [PATCH 1/2] amd_nb: Add PCI ID for family 19h model 78h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 May 2023 19:51:42 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@....com>
To:     Sasha Levin <sashal@...nel.org>
CC:     Thorsten Leemhuis <linux@...mhuis.info>,
        Linux regressions mailing list <regressions@...ts.linux.dev>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Hans de Goede <hdegoede@...hat.com>,
        "S-k, Shyam-sundar" <Shyam-sundar.S-k@....com>,
        "Goswami, Sanket" <Sanket.Goswami@....com>,
        "Gong, Richard" <Richard.Gong@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Borislav Petkov <bp@...en8.de>,
        Guenter Roeck <linux@...ck-us.net>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH 1/2] amd_nb: Add PCI ID for family 19h model 78h

[AMD Official Use Only - General]

+stable, Sasha

> > Together with this patch there are now at least two regressions if
> > -rc1 whch could have been avoided and may impact testability on
> > affected systems.
>
> Are you saying that this patch which fixes s2idle on some random box
> should've gone to Linus *immediately*?
>
> And read my mail again:
>
> "Some fixes need longer testing because there have been cases where
> a fix breaks something else."
>
> So yes, I disagree with rushing fixes immediately. If they're obvious
> - whatever that means - then sure but not all of them are such.
>
> --

Unfortunately, it looks like the broken commit got backported into 6.1.28,
but the fix still isn't in Linus' tree.

Sasha,

Can you please pick up
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/urgent&id=23a5b8bb022c1e071ca91b1a9c10f0ad6a0966e9
for 6.1.29 to fix the regression?

Thanks,