linux-kernel - Re: [PATCH v2] nvme: host: hwmon: constify pointers to hwmon_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <38162cf3-44e8-4774-b60b-539075369699@roeck-us.net>
Date:   Thu, 11 May 2023 13:44:15 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nvme: host: hwmon: constify pointers to
 hwmon_channel_info

On Thu, May 11, 2023 at 07:46:50PM +0200, Krzysztof Kozlowski wrote:
> Statically allocated array of pointed to hwmon_channel_info can be made
> const for safety.
> 
> Acked-by: Christoph Hellwig <hch@....de>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Acked-by: Guenter Roeck <linux@...ck-us.net>

> 
> ---
> 
> Changes since v1:
> 1. Correct whitespace (Christoph)
> 2. Add tag
> ---
>  drivers/nvme/host/hwmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/hwmon.c b/drivers/nvme/host/hwmon.c
> index 9e6e56c20ec9..6aa153f3178a 100644
> --- a/drivers/nvme/host/hwmon.c
> +++ b/drivers/nvme/host/hwmon.c
> @@ -185,7 +185,7 @@ static umode_t nvme_hwmon_is_visible(const void *_data,
>  	return 0;
>  }
>  
> -static const struct hwmon_channel_info *nvme_hwmon_info[] = {
> +static const struct hwmon_channel_info *const nvme_hwmon_info[] = {
>  	HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ),
>  	HWMON_CHANNEL_INFO(temp,
>  			   HWMON_T_INPUT | HWMON_T_MAX | HWMON_T_MIN |
> -- 
> 2.34.1
>