linux-kernel - Re: [PATCH 1/3] KEYS: DigitalSignature link restriction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 May 2023 22:48:02 +0000
From:   Eric Snowberg <eric.snowberg@...cle.com>
To:     Jarkko Sakkinen <jarkko@...nel.org>
CC:     Mimi Zohar <zohar@...ux.ibm.com>,
        David Howells <dhowells@...hat.com>,
        David Woodhouse <dwmw2@...radead.org>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "dmitry.kasatkin@...il.com" <dmitry.kasatkin@...il.com>,
        "paul@...l-moore.com" <paul@...l-moore.com>,
        "jmorris@...ei.org" <jmorris@...ei.org>,
        "serge@...lyn.com" <serge@...lyn.com>, joeyli <jlee@...e.com>,
        Kanth Ghatraju <kanth.ghatraju@...cle.com>,
        Konrad Wilk <konrad.wilk@...cle.com>,
        "keyrings@...r.kernel.org" <keyrings@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH 1/3] KEYS: DigitalSignature link restriction



> On May 10, 2023, at 4:34 PM, Jarkko Sakkinen <jarkko@...nel.org> wrote:
> 
> On Tue May 9, 2023 at 1:07 AM EEST, Eric Snowberg wrote:
>> Add a new link restriction.  Restrict the addition of keys in a keyring
>> based on the key having digitalSignature usage set. Additionally, verify
>> the new certificate against the ones in the system keyrings.  Add two
>> additional functions to use the new restriction within either the builtin
>> or secondary keyrings.
>> 
>> Signed-off-by: Eric Snowberg <eric.snowberg@...cle.com>
>> ---
>> certs/system_keyring.c            | 52 +++++++++++++++++++++++++++++++
>> crypto/asymmetric_keys/restrict.c | 44 ++++++++++++++++++++++++++
>> include/crypto/public_key.h       | 11 +++++++
>> include/keys/system_keyring.h     | 11 +++++++
>> 4 files changed, 118 insertions(+)
>> 
>> diff --git a/certs/system_keyring.c b/certs/system_keyring.c
>> index a7a49b17ceb1..4249c49bd43b 100644
>> --- a/certs/system_keyring.c
>> +++ b/certs/system_keyring.c
>> @@ -51,6 +51,27 @@ int restrict_link_by_builtin_trusted(struct key *dest_keyring,
>> 					  builtin_trusted_keys);
>> }
>> 
>> +/**
>> + * restrict_link_by_digsig_builtin - Restrict digitalSignature key additions
>> + *   by the built-in keyring.
> 
> BTW, does checkpatch complain if you put that to a single line (I don't
> know this)?
> 
> If not, I would just put "Restrict by digitalSignature”

It looks like check patch will allow up to 100 chars.  I will update it to a single line.
Thanks.