linux-kernel - Re: [PATCH] RDMA/core: Use fdget() and fdput()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230511054236.GJ3390869@ZenIV>
Date:   Thu, 11 May 2023 06:42:36 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     ye.xingchen@....com.cn
Cc:     jgg@...pe.ca, leon@...nel.org, jiangjian@...rlc.com,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/core: Use fdget() and fdput()

On Fri, May 05, 2023 at 11:33:57AM +0800, ye.xingchen@....com.cn wrote:
> From: Ye Xingchen <ye.xingchen@....com.cn>
> 
> convert the fget()/fput() uses to fdget()/fdput().

NAK on the entire series.  *IF* you do that kind of replacements,
you need to understand what you are doing; it's not "fdget() is
like fget(), only better; using it will improve things".

	If that comes from seeing my patch series doing fget() to
fdget() conversions, you might consider the possibility that
I *do* know how to use grep.  And that there might be some
objective difference between the instances that had been changed
and the one that had been left alone.  You could try to figure it
out.  Or look through the list archives.  Or ask...

	Al, more than slightly offended by the implications ;-/