linux-kernel - Re: [PATCH v3] blk-throttle: Fix io statistics for cgroup v1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZfGtV8FUoBzhPjFu8V5=e=dQ3wRm+qK7S0HHCB22cjKDLAdQ@mail.gmail.com>
Date:   Thu, 11 May 2023 14:38:00 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     Jinke Han <hanjinke.666@...edance.com>
Cc:     tj@...nel.org, josef@...icpanda.com, axboe@...nel.dk,
        cgroups@...r.kernel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, andrea.righi@...onical.com
Subject: Re: [PATCH v3] blk-throttle: Fix io statistics for cgroup v1

On Mon, May 8, 2023 at 1:07 AM Jinke Han <hanjinke.666@...edance.com> wrote:
>
> From: Jinke Han <hanjinke.666@...edance.com>
>
> After commit f382fb0bcef4 ("block: remove legacy IO schedulers"),
> blkio.throttle.io_serviced and blkio.throttle.io_service_bytes become
> the only stable io stats interface of cgroup v1, and these statistics
> are done in the blk-throttle code. But the current code only counts the
> bios that are actually throttled. When the user does not add the throttle
> limit, the io stats for cgroup v1 has nothing. I fix it according to the
> statistical method of v2, and made it count all ios accurately.
>
> Fixes: a7b36ee6ba29 ("block: move blk-throtl fast path inline")
> Tested-by: Andrea Righi <andrea.righi@...onical.com>
> Signed-off-by: Jinke Han <hanjinke.666@...edance.com>

Good catch.

Acked-by: Muchun Song <songmuchun@...edance.com>

Thanks.