linux-kernel - RE: [PATCH rcu 3/6] rcu/rcuscale: Move rcu_scale_*() after kfree_scale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6171FA965F8FF915621482E789749@IA1PR11MB6171.namprd11.prod.outlook.com>
Date:   Thu, 11 May 2023 07:01:59 +0000
From:   "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To:     Joel Fernandes <joel@...lfernandes.org>,
        "Paul E. McKenney" <paulmck@...nel.org>
CC:     "rcu@...r.kernel.org" <rcu@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-team@...a.com" <kernel-team@...a.com>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>
Subject: RE: [PATCH rcu 3/6] rcu/rcuscale: Move rcu_scale_*() after
 kfree_scale_cleanup()

> From: Joel Fernandes <joel@...lfernandes.org>
> Sent: Thursday, May 11, 2023 1:23 PM
> To: Paul E. McKenney <paulmck@...nel.org>
> Cc: rcu@...r.kernel.org; linux-kernel@...r.kernel.org; kernel-
> team@...a.com; rostedt@...dmis.org; Zhuo, Qiuxu
> <qiuxu.zhuo@...el.com>
> Subject: Re: [PATCH rcu 3/6] rcu/rcuscale: Move rcu_scale_*() after
> kfree_scale_cleanup()
> 
> On Wed, May 10, 2023 at 10:12 AM Paul E. McKenney <paulmck@...nel.org>
> wrote:
> >
> > From: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
> >
> > This code-movement-only commit moves the rcu_scale_cleanup() and
> > rcu_scale_shutdown() functions to follow kfree_scale_cleanup().
> > This is code movement is in preparation for a bug-fix patch that
> > invokes
> > kfree_scale_cleanup() from rcu_scale_cleanup().
> >
> > Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
> > Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> > ---
> >  kernel/rcu/rcuscale.c | 194
> > +++++++++++++++++++++---------------------
> >  1 file changed, 97 insertions(+), 97 deletions(-)
> 
> I wish diff was better at showing what really changed. The meld tool can help
> but its gui...
> 
> Should I run meld later (I'm out at a conference so no access to meld-capable
> machines) or are we sufficiently confident that the lines were moved as-is ? :)
> 

Thank you, Joel for this concern. Good to know the meld diff GUI tool. 
I just run the command below and confirmed that the lines were moved 
as-is: rcu_scale_{cleanup,shutdown}() follows kfree_scale_cleanup().
You may double check it ;-).

      meld --diff ./rcuscale.c.before ./rcuscale.c.after

-Qiuxu

>  - Joel