linux-kernel - Re: (subset) [PATCH] drm: sun4i_tcon: use devm_clk_get_enabled in `sun4i_tcon_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168379036200.796072.421403145532970427.b4-ty@cerno.tech>
Date:   Thu, 11 May 2023 09:32:42 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Maxime Ripard <mripard@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        XuDong Liu <m202071377@...t.edu.cn>
Cc:     hust-os-kernel-patches@...glegroups.com,
        Dongliang Mu <dzm91@...t.edu.cn>,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: (subset) [PATCH] drm: sun4i_tcon: use devm_clk_get_enabled in
 `sun4i_tcon_init_clocks`

On Sun, 30 Apr 2023 19:23:46 +0800, XuDong Liu wrote:
> Smatch reports:
> drivers/gpu/drm/sun4i/sun4i_tcon.c:805 sun4i_tcon_init_clocks() warn:
> 'tcon->clk' from clk_prepare_enable() not released on lines: 792,801.
> 
> In the function sun4i_tcon_init_clocks(), tcon->clk and tcon->sclk0 are
> not disabled in the error handling, which affects the release of
> these variable. Although sun4i_tcon_bind(), which calls
> sun4i_tcon_init_clocks(), use sun4i_tcon_free_clocks to disable the
> variables mentioned, but the error handling branch of
> sun4i_tcon_init_clocks() ignores the required disable process.
> 
> [...]

Applied to drm/drm-misc (drm-misc-next).

Thanks!
Maxime