linux-kernel - Re: [PATCH -next] gpio: ixp4xx: Use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MdMm4hwSWV4PpzEVeXmAmTSRbLEODj4G_m4rR0rYUVNKA@mail.gmail.com>
Date:   Thu, 11 May 2023 11:08:09 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     linusw@...nel.org, kaloz@...nwrt.org, khalasa@...p.pl,
        linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] gpio: ixp4xx: Use devm_platform_ioremap_resource()

On Fri, Apr 28, 2023 at 8:09 AM Yang Li <yang.lee@...ux.alibaba.com> wrote:
>
> Convert platform_get_resource(),devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource(), as this is exactly what this
> function does.
>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/gpio/gpio-ixp4xx.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c
> index 56656fb519f8..1e29de1671d4 100644
> --- a/drivers/gpio/gpio-ixp4xx.c
> +++ b/drivers/gpio/gpio-ixp4xx.c
> @@ -199,7 +199,6 @@ static int ixp4xx_gpio_probe(struct platform_device *pdev)
>         struct device *dev = &pdev->dev;
>         struct device_node *np = dev->of_node;
>         struct irq_domain *parent;
> -       struct resource *res;
>         struct ixp4xx_gpio *g;
>         struct gpio_irq_chip *girq;
>         struct device_node *irq_parent;
> @@ -210,8 +209,7 @@ static int ixp4xx_gpio_probe(struct platform_device *pdev)
>                 return -ENOMEM;
>         g->dev = dev;
>
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       g->base = devm_ioremap_resource(dev, res);
> +       g->base = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(g->base))
>                 return PTR_ERR(g->base);
>
> --
> 2.20.1.7.g153144c
>

Applied, thanks!

Bart