linux-kernel - Re: [PATCH] cpufreq: imx6q: Disable only available frequencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230511095355.5t7ldsyg5eglrrtv@vireshk-i7>
Date:   Thu, 11 May 2023 15:23:55 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Christoph Niedermaier <cniedermaier@...electronics.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>, Marek Vasut <marex@...x.de>,
        Fabio Estevam <festevam@...x.de>,
        NXP Linux Team <linux-imx@....com>,
        "open list:CPU FREQUENCY SCALING FRAMEWORK" 
        <linux-pm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: imx6q: Disable only available frequencies

On 11-05-23, 11:23, Christoph Niedermaier wrote:
> @@ -254,16 +269,16 @@ static int imx6q_opp_check_speed_grading(struct device *dev)
>  	val &= 0x3;
>  
>  	if (val < OCOTP_CFG3_SPEED_996MHZ)
> -		if (dev_pm_opp_disable(dev, 996000000))
> +		if (disable_freq_if_available(dev, 996000000))
>  			dev_warn(dev, "failed to disable 996MHz OPP\n");

Ahh, these warnings.

What about printing the warning only when returned error != -ENODEV ?
Or just marking them dev_dbg() ?

-- 
viresh