linux-kernel - Re: [PATCH v8 4/6] KVM: x86: Introduce untag_addr() in kvm_x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZFzFfZkZtcc37x2A@chao-email>
Date:   Thu, 11 May 2023 18:37:49 +0800
From:   Chao Gao <chao.gao@...el.com>
To:     Binbin Wu <binbin.wu@...ux.intel.com>
CC:     <kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <seanjc@...gle.com>, <pbonzini@...hat.com>, <kai.huang@...el.com>,
        <robert.hu@...ux.intel.com>
Subject: Re: [PATCH v8 4/6] KVM: x86: Introduce untag_addr() in kvm_x86_ops

On Thu, May 11, 2023 at 05:18:31PM +0800, Binbin Wu wrote:
>> > +	if (sign_ext_bit > 0)
>> > +		*la = (sign_extend64(*la, sign_ext_bit) & ~BIT_ULL(63)) |
>> > +		       (*la & BIT_ULL(63));
>> nit: curly braces are needed.
>Even if it's only one statement (although splited to two lines), curly braces
>are needed?

I was under the impression somehow -- braces are needed if the statement
is split into two lines. But Sean said [1] curly braces are not needed
in this case. Thus, please disregard my comment.

[1]: https://lore.kernel.org/all/Y9B9Ey1hK9A7NDVb@google.com/