linux-kernel - Re: [PATCH] firewire: net: fix unexpected release of object for asynchronous request packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230511000830.GA796953@workstation>
Date:   Thu, 11 May 2023 09:08:30 +0900
From:   Takashi Sakamoto <o-takashi@...amocchi.jp>
To:     linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Cc:     Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH] firewire: net: fix unexpected release of object for
 asynchronous request packet

On Wed, May 10, 2023 at 12:12:05PM +0900, Takashi Sakamoto wrote:
> The lifetime of object for asynchronous request packet is now maintained
> by reference counting, while current implementation of firewire-net
> releases the passed object in the handler.
> 
> This commit fixes the bug.
> 
> Reported-by: Dan Carpenter <error27@...il.com>
> Link: https://lore.kernel.org/lkml/Y%2Fymx6WZIAlrtjLc@workstation/
> Fixes: 13a55d6bb15f ("firewire: core: use kref structure to maintain lifetime of data for fw_request structure")
> Signed-off-by: Takashi Sakamoto <o-takashi@...amocchi.jp>
> ---
>  drivers/firewire/net.c | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)

The patch is applied to for-linus branch and will be sent to mainline
within a few days.


Regards

Takashi Sakamoto