lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3a8e10f6-ea98-4c6d-b89e-06d659365acb@lunn.ch>
Date:   Thu, 11 May 2023 16:16:03 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Harini Katakam <harini.katakam@....com>
Cc:     hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        kuba@...nel.org, edumazet@...gle.com, pabeni@...hat.com,
        vladimir.oltean@....com, wsa+renesas@...g-engineering.com,
        simon.horman@...igine.com, mkl@...gutronix.de,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        harinikatakamlinux@...il.com, michal.simek@....com,
        radhey.shyam.pandey@....com
Subject: Re: [PATCH net-next v3 3/3] phy: mscc: Add support for VSC8531_02

On Thu, May 11, 2023 at 05:38:08PM +0530, Harini Katakam wrote:
> Add support for VSC8531_02 (Rev 2) device. Use exact PHY ID match.

Please add a comment:

Rev 2 requires its own entry so that...

Just to make it clear why the existing PHY_ID_VSC853/0xfffffff0 is not
sufficient.

	Andrew

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ