lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202305111044.dALqNbL3-lkp@intel.com>
Date:   Thu, 11 May 2023 11:00:44 +0800
From:   kernel test robot <lkp@...el.com>
To:     Stafford Horne <shorne@...il.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: drivers/net/wireless/intel/iwlegacy/4965-mac.c:1653:29: warning:
 variable 'out_meta' set but not used

Hi Stafford,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   d295b66a7b66ed504a827b58876ad9ea48c0f4a8
commit: ded2ee36313c941f1a12b6f85cde295b575264ae openrisc: Add pci bus support
date:   10 months ago
config: openrisc-buildonly-randconfig-r001-20230511 (https://download.01.org/0day-ci/archive/20230511/202305111044.dALqNbL3-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ded2ee36313c941f1a12b6f85cde295b575264ae
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout ded2ee36313c941f1a12b6f85cde295b575264ae
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/net/wireless/intel/iwlegacy/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305111044.dALqNbL3-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/wireless/intel/iwlegacy/4965-mac.c: In function 'il4965_tx_skb':
>> drivers/net/wireless/intel/iwlegacy/4965-mac.c:1653:29: warning: variable 'out_meta' set but not used [-Wunused-but-set-variable]
    1653 |         struct il_cmd_meta *out_meta;
         |                             ^~~~~~~~


vim +/out_meta +1653 drivers/net/wireless/intel/iwlegacy/4965-mac.c

a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1638  
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1639  /*
4d69c7521a90cb drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-08-30  1640   * start C_TX command process
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1641   */
e7392364fcd100 drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1642  int
36323f817af037 drivers/net/wireless/iwlegacy/4965-mac.c Thomas Huehn      2012-07-23  1643  il4965_tx_skb(struct il_priv *il,
36323f817af037 drivers/net/wireless/iwlegacy/4965-mac.c Thomas Huehn      2012-07-23  1644  	      struct ieee80211_sta *sta,
36323f817af037 drivers/net/wireless/iwlegacy/4965-mac.c Thomas Huehn      2012-07-23  1645  	      struct sk_buff *skb)
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1646  {
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1647  	struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1648  	struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1649  	struct il_station_priv *sta_priv = NULL;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1650  	struct il_tx_queue *txq;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1651  	struct il_queue *q;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1652  	struct il_device_cmd *out_cmd;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15 @1653  	struct il_cmd_meta *out_meta;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1654  	struct il_tx_cmd *tx_cmd;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1655  	int txq_id;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1656  	dma_addr_t phys_addr;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1657  	dma_addr_t txcmd_phys;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1658  	dma_addr_t scratch_phys;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1659  	u16 len, firstlen, secondlen;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1660  	u16 seq_number = 0;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1661  	__le16 fc;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1662  	u8 hdr_len;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1663  	u8 sta_id;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1664  	u8 wait_write_ptr = 0;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1665  	u8 tid = 0;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1666  	u8 *qc = NULL;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1667  	unsigned long flags;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1668  	bool is_agg = false;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1669  
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1670  	spin_lock_irqsave(&il->lock, flags);
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1671  	if (il_is_rfkill(il)) {
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1672  		D_DROP("Dropping - RF KILL\n");
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1673  		goto drop_unlock;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1674  	}
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1675  
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1676  	fc = hdr->frame_control;
a1751b22a82e6c drivers/net/wireless/iwlegacy/4965-mac.c Stanislaw Gruszka 2011-11-15  1677  

:::::: The code at line 1653 was first introduced by commit
:::::: a1751b22a82e6cd2da6c9e79611cfd6d6aba1d39 iwlegacy: merge iwl-4965-{tx,rx}.c into 4965-mac.c

:::::: TO: Stanislaw Gruszka <sgruszka@...hat.com>
:::::: CC: Stanislaw Gruszka <sgruszka@...hat.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ