linux-kernel - Re: [PATCH] PCI: microchip: Avoid cast to incompatible function type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230511-coming-saturate-a2ae32462a3a@spud>
Date:   Thu, 11 May 2023 16:30:52 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Simon Horman <horms@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Daire McNamara <daire.mcnamara@...rochip.com>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, linux-riscv@...ts.infradead.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] PCI: microchip: Avoid cast to incompatible function type

On Thu, May 11, 2023 at 05:24:18PM +0200, Simon Horman wrote:
> Rather than casting clk_disable_unprepare to an incompatible function type,
> update the type to match that expected by devm_add_action_or_reset.
> 
> Reported by clang-16 with W-1:
> 
>  .../pcie-microchip-host.c:866:32: warning: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Wcast-function-type-strict]
>          devm_add_action_or_reset(dev, (void (*) (void *))clk_disable_unprepare,
>                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  ./include/linux/device.h:265:38: note: expanded from macro 'devm_add_action_or_reset'
>          __devm_add_action_or_reset(release, action, data, #action)
>                                              ^~~~~~
> No functional change intended.
> Compile tested only.
> 

Yeah, there's already a patch for this:
https://lore.kernel.org/linux-pci/20230111125323.1911373-3-daire.mcnamara@microchip.com/

The lads didn't want to pick any of that piecemeal & Daire hasn't been
able to get back to that work until this week.

I don't think we an ETA though on a v4, so:
Fixes: 6f15a9c9f941 ("PCI: microchip: Add Microchip PolarFire PCIe controller driver")
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
and I don't know if you wanna propagate the:
| Reported-by: kernel test robot <lkp@...el.com>

Thanks,
Conor.

> Signed-off-by: Simon Horman <horms@...nel.org>
> ---
>  drivers/pci/controller/pcie-microchip-host.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/pcie-microchip-host.c b/drivers/pci/controller/pcie-microchip-host.c
> index 5e710e485464..d8aa6e3cdbff 100644
> --- a/drivers/pci/controller/pcie-microchip-host.c
> +++ b/drivers/pci/controller/pcie-microchip-host.c
> @@ -848,6 +848,11 @@ static const struct irq_domain_ops event_domain_ops = {
>  	.map = mc_pcie_event_map,
>  };
>  
> +inline void mc_clk_disable_unprepare(void *data)
> +{
> +	clk_disable_unprepare(data);
> +}
> +
>  static inline struct clk *mc_pcie_init_clk(struct device *dev, const char *id)
>  {
>  	struct clk *clk;
> @@ -863,8 +868,7 @@ static inline struct clk *mc_pcie_init_clk(struct device *dev, const char *id)
>  	if (ret)
>  		return ERR_PTR(ret);
>  
> -	devm_add_action_or_reset(dev, (void (*) (void *))clk_disable_unprepare,
> -				 clk);
> +	devm_add_action_or_reset(dev, mc_clk_disable_unprepare, clk);
>  
>  	return clk;
>  }
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)